I am learning TCL too and feel I can assist in some of this for you.
The reason why you get an invalid argument is because you are using argv which only accepts arguments when you are calling a tcl script to run from a command line and you add arguments at the end to feed into the script dynamically.
eg if you save a script called pingtest.tcl into the routers flash, then after the .tcl are your arguments that argv will soak in
in otherwors "Command line arguments are stored in the list named 'argv"
pingtest.tcl 192.168.1.1 192.168.1.2 192.168.1.3 etc etc
I would recommend for now just turning it into a proc which you can use in the interactive tcl shell on the router. After you do that then you can branch off into saving it into flash or whatever.
To turn it into a procedure you can forget about the argv stuff and just put the ip address directly into the proc argument.
This means that when you call your proc name it will execute the procedure body using the argument in the proc.
have a go at this. To make it neater you can create a placeholder variable for all the IP's you want to validate.
What this will do is, if the ping is succesfull then it will go on to execute the traceroute.
however if the ping fails then no traceroute is executed and it goes on to the next IP in the list.
eg -
set ip "192.168.1.1 192.168.1.2 192.168.1.3 192.168.1.4 192.168.11.5 192.168.12.5 192.168.1.5 192.168.1.6 184.32.33.1 192.168.1.7 192.168.1.8 192.168.1.9 192.168.1.10"
----------------------------------------------------------------------------
Copy this into your routers interactive shell
----------------------------------------------------------------------------
set ip "192.168.1.1 192.168.1.2 192.168.1.3 192.168.1.4 192.168.11.5 192.168.12.5 192.168.1.5 192.168.1.6 184.32.33.1 192.168.1.7 192.168.1.8 192.168.1.9 192.168.1.10"
proc validate {x} {
set counter 1
puts "###########################"
puts "# Running Ping Validation #"
puts "###########################\n\n"
foreach ip_address $x {
set pings [exec ping $ip_address]
if {[regexp {!!!!} $pings]} {
puts "Analysing Ping $counter to IP - $ip_address"
puts "Ping to $ip_address - \[SUCCESSFULL\]\n\n"
puts "*****Validating path to $ip_address via traceroute*****"
traceroute $ip_address
puts \n
puts "\[COMPLETED\]\n\n"
puts -----------------------------------------------------------
puts \n\n
} else {
puts "Analysing Ping $counter to IP - $ip_address"
puts "Ping to $ip_address - \[FAIL\]\n\n"
puts -----------------------------------------------------------
}
incr counter
}
}
validate $ip
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
END
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-also its worth to note the tcl traceroute command is finiky, if you use exec it most likely wont work and just hang until all 30 hops are done. (potentially ios version dependant as I have read a couple of Josephs posts on similar issues with it)
It would be easy to convert back into argv. Just replace to foreach ip_address $argv and get rid of the procedure.
