here is my comments :
1 to 1 NAT to phone server with TCP & UDP ports forwarded.
BB - 1 to 1 NAT between you and SIP provider Public IP to Private IP - required ports for SIP trunking, allowed ACL in place.
SIP Inspection on or off? I've seen mixed results of information.
Inspection Off.
Phone server and phones on it's own isolated VLAN.
BB -yes, i believe you have voice and data VLAN in place with DHCP, you need DHCP option for Phone to register.