Hello,
this is a duplicated thread see my answer in Switching section.
You have missing parts in configuration of NAT as showed in a previous thread of yours , the PPPoE works because the virtual-access interface is up/up and the client gets an address.
The question is the client gets a private address (see RFC 1918) that has to be translated by NAT in order to be able to access the public internet.
I would suggest to go on in the other thread.
Best Regards
Giuseppe