QoS configuration for access and trunk ports

[cmvictoria]

I'm trying to fix all the QoS inconsistencies in our switch environment. Below are the configs that I think are correct to use. I'm looking for any feedback for improvement or lines that I could leave off. The Cisco phones that we primarily use are the 7962, 8841, and 8851. Video units are EX60, DX80, SX80 and spark room kits. Thank you in advance.

class-map match-all AUTOQOS_VOIP_DATA_CLASS

 match ip dscp ef

class-map match-all AUTOQOS_DEFAULT_CLASS

 match access-group name AUTOQOS-ACL-DEFAULT

class-map match-all AUTOQOS_VOIP_SIGNAL_CLASS

 match ip dscp cs3

!

policy-map AUTOQOS-SRND4-CISCOPHONE-POLICY

 class AUTOQOS_VOIP_DATA_CLASS

  set dscp ef

  police 128000 8000 exceed-action policed-dscp-transmit

 class AUTOQOS_VOIP_SIGNAL_CLASS

  set dscp cs3

  police 32000 8000 exceed-action policed-dscp-transmit

 class AUTOQOS_DEFAULT_CLASS

  set dscp default

  police 10000000 8000 exceed-action policed-dscp-transmit

Access Ports

 srr-queue bandwidth share 1 30 35 5

 priority-queue out

 no snmp trap link-status

 mls qos trust device cisco-phone

 mls qos trust cos

 auto qos voip cisco-phone

 spanning-tree portfast

 service-policy input AUTOQOS-SRND4-CISCOPHONE-POLICY

Trunk Ports

 srr-queue bandwidth share 1 30 35 5

 priority-queue out

 mls qos trust dscp

 auto qos voip trust

 spanning-tree portfast disable

[cmarva]

I see you are using auto qos. Now, you don't specify the platform, so syntax will differ based on platforms. But with an OOB config (IE - blank), I let the switch do the work:

vlan 2

 name data

vlan 3

 name voice

!

auto qos srnd4

!

int range g1/0/1 - 24

switchport access vlan 2

switchport voice vlan 3

auto qos voip cisco-phone

!

and the switch will auto generate the necessary config. You don't have to worry about creating your own. I have found some instances where auto qos isn't a good fit, but more often than not it works fine. 

[cmvictoria]

For switching purposes we're using 2960, 2960S and 2960X. The switches are strictly layer 2 traffic.

[cmvictoria]

Would my trunk port configuration change?